Fix literal free when show opcodes is enabled.#2398
Merged
zherczeg merged 1 commit intojerryscript-project:masterfrom Jun 18, 2018
Merged
Fix literal free when show opcodes is enabled.#2398zherczeg merged 1 commit intojerryscript-project:masterfrom
zherczeg merged 1 commit intojerryscript-project:masterfrom
Conversation
Member
|
@zherczeg If there is a known problematic test case why not add it to the test suite? (Even if it hardly triggers an issue with the current test execution settings, it may be valuable to save it with a comment attached about the details.) |
A literal might be not freed if it is stored in a register, and PARSER_DUMP_BYTE_CODE is enabled, but opcodes are not shown. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
show_opcodes_fix
branch
from
1888c1d to
4655b03
Compare
Member
Author
|
Thank you for the review. A test case is added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A literal might be not freed if it is stored in a register, and PARSER_DUMP_BYTE_CODE is enabled, but opcodes are not shown.
It is easy to trigger, but there is no test for this:
function f(){var \u0042 = true;};